Use the new dedicated Synapse API #4801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
ee9f843
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ca2ae2a3.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-new-synapse-api.matrix-authentication-service-docs.pages.dev |
sandhose
force-pushed
the
quenting/new-synapse-api
branch
from
4bb422f to
c649603
Compare
sandhose
added a commit
to element-hq/synapse
that referenced
this pull request
Jul 21, 2025
This introduces a dedicated API for MAS to consume. Companion PR on the MAS side: element-hq/matrix-authentication-service#4801 This has a few advantages over the previous admin API: - it works on workers (this will be documented once we stabilise MSC3861 as a whole) - it is more efficient because more focused - it propagates trace contexts from MAS - it is only accessible to MAS (through the shared secret) and will let us remove the weird hack that made this token 'admin' with a ghost '@__oidc_admin:' user The next MAS version should support it, but will be opt-in. The version after that should use this new API by default --------- Co-authored-by: Eric Eastwood <erice@element.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for using the new dedicated 'MAS' API in Synapse for MAS->Synapse communication introduced in element-hq/synapse#18520
This removes the dependency on the Synapse admin API, making it more focused, and will let us remove the fact that the shared secret is effectively a site-wide admin token.
I've kept the old implementation around so that we can gradually roll this out. The plan is:
synapse_modernhomeserver type)synapse_legacyhomeserver type)